mandriva

Ticket #243 (new defect)

Opened 6 months ago

Last modified 6 months ago

"Add computer" tab

Reported by: matthieu.vogelweith@mandriva.com Assigned to: cdelfosse
Priority: normal Milestone: 2.4.0
Component: general Version: 2.3.1
Severity: normal Keywords: samba, smbldap-tools
Cc:

Description

Hi,

I don't find an existing tickets for this problem.

The "add computer" tab should removed in the samba plugin. This function is useless and often disrupts users.

Regards, Mat

Attachments

Change History

07/14/08 15:40:03 changed by sasha@tactel.com.ua

  • keywords set to samba, smbldap-tools.

It can be useful after some re-factoring. It can be used to give some meaning comment to a new Workstations.

After updating smbldap-tools to version 0.9.5 (in CentOS 5.2), new parameter "-W" in smbldap-useradd is used to add "a Windows Workstation, with Samba atributes (otherwise, Posix stuff only)"(smbldap-tools Changelog) and there are no need to create a LDAP-skeleton for PC (in mmc/plugins/samba) and afterwards modify it with other tools (like I wrote earlier in my bugreports)

So my proposal is: adapt samba python plug-in to add Workstation via smbldap-tools (/usr/sbin/smbldap-useradd -W uid -c comment) and adapt /usr/local/lib/mmc/add_machine_script to work with it.

Current version of MMC don't work smoothly with smbldap-tools, if I just modify "cmd" line in /mmc/plugins/samba/init.py to

string 491

...
if not addMachineScript:
#cmd = 'smbpasswd -a -m ' + uid
cmd = '/usr/sbin/smbldap-useradd -W' + uid
shProcess = generateBackgroundProcess(cmd)
ret = shProcess.getExitCode()
...

So I just commented old one, added an empty 'cmd' statement, and changed in samb.conf:

add machine script = /usr/sbin/smbldap-useradd -W "%u"

So now clicking to Add machine do nothing, Workstations added via smbldap-tools with default comment.


Add/Change #243 ("Add computer" tab)




Change Properties
Action